Skip to content

feat: emit BotThinking events with reasoning traces #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2025
Merged

feat: emit BotThinking events with reasoning traces #1432

merged 5 commits into from
Oct 13, 2025

Conversation

Pouyanpi
Copy link
Collaborator

@Pouyanpi Pouyanpi commented Oct 1, 2025 •
edited
Loading

Stack Info

This PR is part of a stack:

  1. refactor!: drop reasoning trace extraction logic #1427
  2. feat: add reasoning trace extraction from llm calls #1431
  3. feat: emit BotThinking events with reasoning traces #1432 (this PR)
  4. feat(logging): improve event logging and add bot thinking display #1434

⚠️ Depends on:

#1427 → #1431

Description

Extracts reasoning traces from LLM responses and emits BotThinking
events before BotMessage events. Adds bot_thinking_content to context
for use in output rails.

@Pouyanpi Pouyanpi changed the title Feat/bot thinking events feat: emit BotThinking events with reasoning traces Oct 1, 2025
@Pouyanpi Pouyanpi added this to the v0.18.0 milestone Oct 2, 2025
This was referenced Oct 2, 2025
Merged
Merged
Merged
@tgasser-nv tgasser-nv self-requested a review October 6, 2025 14:58
tgasser-nv
tgasser-nv approved these changes Oct 6, 2025
View reviewed changes
@Pouyanpi Pouyanpi force-pushed the feat/reasoning-trace-extraction-langchain branch 2 times, most recently from 80e3466 to be7223e Compare October 13, 2025 07:59
Base automatically changed from feat/reasoning-trace-extraction-langchain to develop October 13, 2025 08:09
@Pouyanpi
feat: emit BotThinking events with reasoning traces
5c3213d 
Extracts reasoning traces from LLM responses and emits BotThinking
events before BotMessage events. Adds bot_thinking_content to context
for use in output rails.
@Pouyanpi
feat: bot thinking in self check output rails
0028a26
@Pouyanpi
docs(example): add self check output rails for bot thinking
81290d5
@Pouyanpi
add mroe tests
98c8911
@Pouyanpi Pouyanpi force-pushed the feat/bot-thinking-events branch from 8ae50ef to 98c8911 Compare October 13, 2025 08:13
@NVIDIA-NeMo NVIDIA-NeMo deleted a comment from codecov-commenter Oct 13, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
nemoguardrails/actions/llm/generation.py 73.33% 8 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Pouyanpi Pouyanpi merged commit 59d1a6d into develop Oct 13, 2025
8 checks passed
@Pouyanpi Pouyanpi deleted the feat/bot-thinking-events branch October 13, 2025 09:04
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
@Pouyanpi @tgasser-nv
feat(bot-thinking): emit BotThinking events with reasoning traces (#1432
6666e51 
)

Extracts reasoning traces from LLM responses and emits BotThinking
events before BotMessage events. Adds bot_thinking_content to context
for use in output rails.

* feat: bot thinking in self check output rails

* docs(example): add self check output rails for bot thinking
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
@Pouyanpi @tgasser-nv
feat(bot-thinking): emit BotThinking events with reasoning traces (#1432
d975198 
)

Extracts reasoning traces from LLM responses and emits BotThinking
events before BotMessage events. Adds bot_thinking_content to context
for use in output rails.

* feat: bot thinking in self check output rails

* docs(example): add self check output rails for bot thinking
tgasser-nv pushed a commit that referenced this pull request Oct 14, 2025
@Pouyanpi @tgasser-nv
feat(bot-thinking): emit BotThinking events with reasoning traces (#1432
357b261 
)

Extracts reasoning traces from LLM responses and emits BotThinking
events before BotMessage events. Adds bot_thinking_content to context
for use in output rails.

* feat: bot thinking in self check output rails

* docs(example): add self check output rails for bot thinking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgasser-nv tgasser-nv tgasser-nv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Pouyanpi @codecov-commenter @tgasser-nv